From 7683145678077fe027b27069be32d1b08c8efd4a Mon Sep 17 00:00:00 2001 From: Helmut Grohne Date: Thu, 13 Jun 2013 15:00:39 +0200 Subject: webapp: use sqlalchemy * Arguably the interface is nicer. * Actually closes connections. => wal files get deleted. * Permits switching from sqlite to anything. --- README | 2 +- webapp.py | 166 ++++++++++++++++++++++++++++++-------------------------------- 2 files changed, 82 insertions(+), 86 deletions(-) diff --git a/README b/README index 2d362f9..8c541c1 100644 --- a/README +++ b/README @@ -1,7 +1,7 @@ Required packages ----------------- - aptitude install python python-debian python-lzma curl python-jinja2 python-werkzeug sqlite3 python-imaging + aptitude install python python-debian python-lzma curl python-jinja2 python-werkzeug sqlite3 python-imaging python-sqlalchemy Create a database ----------------- diff --git a/webapp.py b/webapp.py index 6d8b7d1..7a7524b 100755 --- a/webapp.py +++ b/webapp.py @@ -2,10 +2,10 @@ import datetime import os.path -import sqlite3 from wsgiref.simple_server import make_server import jinja2 +import sqlalchemy from werkzeug.exceptions import HTTPException, NotFound from werkzeug.routing import Map, Rule, RequestRedirect from werkzeug.wrappers import Request, Response @@ -247,43 +247,41 @@ class Application(object): return e def get_details(self, package): - cur = self.db.cursor() - cur.execute("SELECT version, architecture FROM package WHERE package = ?;", - (package,)) - row = cur.fetchone() - if not row: - raise NotFound() - version, architecture = row - details = dict(package=package, - version=version, - architecture=architecture) - cur.execute("SELECT count(filename), sum(size) FROM content WHERE package = ?;", - (package,)) - num_files, total_size = cur.fetchone() - if total_size is None: - total_size = 0 - details.update(dict(num_files=num_files, total_size=total_size)) - return details + with self.db.begin() as conn: + row = conn.execute("SELECT version, architecture FROM package WHERE package = ?;", + (package,)).fetchone() + if not row: + raise NotFound() + version, architecture = row + row = conn.execute("SELECT count(filename), sum(size) FROM content WHERE package = ?;", + (package,)).fetchone() + num_files, total_size = row + return dict(package=package, + version=version, + architecture=architecture, + num_files=num_files, + total_size=total_size and 0) # total_size may be None def get_dependencies(self, package): - cur = self.db.cursor() - cur.execute("SELECT required FROM dependency WHERE package = ?;", - (package,)) - return set(row[0] for row in fetchiter(cur)) + with self.db.begin() as conn: + cur = conn.execute("SELECT required FROM dependency WHERE package = ?;", + (package,)) + return set(row[0] for row in fetchiter(cur)) def cached_sharedstats(self, package): - cur = self.db.cursor() sharedstats = {} - cur.execute("SELECT package2, func1, func2, files, size FROM sharing WHERE package1 = ?;", - (package,)) - for package2, func1, func2, files, size in fetchiter(cur): - if (func1, func2) not in hash_functions: - continue - curstats = sharedstats.setdefault( - function_combination(func1, func2), list()) - if package2 == package: - package2 = None - curstats.append(dict(package=package2, duplicate=files, savable=size)) + with self.db.begin() as conn: + cur = conn.execute("SELECT package2, func1, func2, files, size FROM sharing WHERE package1 = ?;", + (package,)) + for package2, func1, func2, files, size in fetchiter(cur): + if (func1, func2) not in hash_functions: + continue + curstats = sharedstats.setdefault( + function_combination(func1, func2), list()) + if package2 == package: + package2 = None + curstats.append(dict(package=package2, duplicate=files, + savable=size)) return sharedstats def show_package(self, package): @@ -303,35 +301,32 @@ class Application(object): * matches: A mapping from filenames in package2 to a mapping from hash function pairs to hash values. """ - cur = self.db.cursor() - cur.execute("SELECT id, filename, size, hash FROM content JOIN hash ON content.id = hash.cid JOIN duplicate ON content.id = duplicate.cid WHERE package = ? AND function = 'sha512' ORDER BY size DESC;", - (package1,)) - cursize = -1 - files = dict() - minmatch = 2 if package1 == package2 else 1 - for cid, filename, size, hashvalue in fetchiter(cur): - if cursize != size: - for entry in files.values(): - if len(entry["matches"]) >= minmatch: - yield entry - files.clear() - cursize = size - - if hashvalue in files: - files[hashvalue]["filenames"].add(filename) - continue - - entry = dict(filenames=set((filename,)), size=size, matches={}) - files[hashvalue] = entry - - cur2 = self.db.cursor() - cur2.execute("SELECT ha.function, ha.hash, hb.function, filename FROM hash AS ha JOIN hash AS hb ON ha.hash = hb.hash JOIN content ON hb.cid = content.id WHERE ha.cid = ? AND package = ?;", - (cid, package2)) - for func1, hashvalue, func2, filename in fetchiter(cur2): - entry["matches"].setdefault(filename, {})[func1, func2] = \ - hashvalue - cur2.close() - cur.close() + with self.db.begin() as conn: + cur = conn.execute("SELECT id, filename, size, hash FROM content JOIN hash ON content.id = hash.cid JOIN duplicate ON content.id = duplicate.cid WHERE package = ? AND function = 'sha512' ORDER BY size DESC;", + (package1,)) + cursize = -1 + files = dict() + minmatch = 2 if package1 == package2 else 1 + for cid, filename, size, hashvalue in fetchiter(cur): + if cursize != size: + for entry in files.values(): + if len(entry["matches"]) >= minmatch: + yield entry + files.clear() + cursize = size + + if hashvalue in files: + files[hashvalue]["filenames"].add(filename) + continue + + entry = dict(filenames=set((filename,)), size=size, matches={}) + files[hashvalue] = entry + + cur = conn.execute("SELECT ha.function, ha.hash, hb.function, filename FROM hash AS ha JOIN hash AS hb ON ha.hash = hb.hash JOIN content ON hb.cid = content.id WHERE ha.cid = ? AND package = ?;", + (cid, package2)) + for func1, hashvalue, func2, filename in fetchiter(cur): + entry["matches"].setdefault(filename, {})[func1, func2] = \ + hashvalue for entry in files.values(): if len(entry["matches"]) >= minmatch: @@ -351,13 +346,13 @@ class Application(object): return html_response(detail_template.stream(params)) def show_hash(self, function, hashvalue): - cur = self.db.cursor() - cur.execute("SELECT content.package, content.filename, content.size, hash.function FROM content JOIN hash ON content.id = hash.cid WHERE hash = ?;", - (hashvalue,)) - entries = [dict(package=package, filename=filename, size=size, - function=otherfunc) - for package, filename, size, otherfunc in fetchiter(cur) - if (function, otherfunc) in hash_functions] + with self.db.begin() as conn: + cur = conn.execute("SELECT content.package, content.filename, content.size, hash.function FROM content JOIN hash ON content.id = hash.cid WHERE hash = ?;", + (hashvalue,)) + entries = [dict(package=package, filename=filename, size=size, + function=otherfunc) + for package, filename, size, otherfunc in fetchiter(cur) + if (function, otherfunc) in hash_functions] if not entries: raise NotFound() params = dict(function=function, hashvalue=hashvalue, entries=entries, @@ -365,26 +360,27 @@ class Application(object): return html_response(hash_template.render(params)) def show_source(self, package): - cur = self.db.cursor() - cur.execute("SELECT package FROM package WHERE source = ?;", - (package,)) - binpkgs = dict.fromkeys(pkg for pkg, in fetchiter(cur)) - if not binpkgs: - raise NotFound - cur.execute("SELECT package.package, sharing.package2, sharing.func1, sharing.func2, sharing.files, sharing.size FROM package JOIN sharing ON package.package = sharing.package1 WHERE package.source = ?;", - (package,)) - for binary, otherbin, func1, func2, files, size in fetchiter(cur): - entry = dict(package=otherbin, - funccomb=function_combination(func1, func2), - duplicate=files, savable=size) - oldentry = binpkgs.get(binary) - if not (oldentry and oldentry["savable"] >= size): - binpkgs[binary] = entry + with self.db.begin() as conn: + cur = conn.execute("SELECT package FROM package WHERE source = ?;", + (package,)) + binpkgs = dict.fromkeys(pkg for pkg, in fetchiter(cur)) + if not binpkgs: + raise NotFound + cur = conn.execute("SELECT package.package, sharing.package2, sharing.func1, sharing.func2, sharing.files, sharing.size FROM package JOIN sharing ON package.package = sharing.package1 WHERE package.source = ?;", + (package,)) + for binary, otherbin, func1, func2, files, size in fetchiter(cur): + entry = dict(package=otherbin, + funccomb=function_combination(func1, func2), + duplicate=files, savable=size) + oldentry = binpkgs.get(binary) + if not (oldentry and oldentry["savable"] >= size): + binpkgs[binary] = entry params = dict(source=package, packages=binpkgs, urlroot="..") return html_response(source_template.render(params)) def main(): - app = Application(sqlite3.connect("test.sqlite3")) + db = sqlalchemy.create_engine("sqlite:///test.sqlite3") + app = Application(db) staticdir = os.path.join(os.path.dirname(__file__), "static") app = SharedDataMiddleware(app, {"/": staticdir}) make_server("0.0.0.0", 8800, app).serve_forever() -- cgit v1.2.3