From d9d757792682e98e006d93f6bcbb94688d3a0f3f Mon Sep 17 00:00:00 2001 From: Helmut Grohne Date: Wed, 29 Dec 2021 21:05:58 +0100 Subject: autoimport: avoid changing variable type knownpkgvers is a dict while knownpkgs is a set. Separating them helps static type checkers. --- autoimport.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/autoimport.py b/autoimport.py index d9ee0a3..eb610b4 100755 --- a/autoimport.py +++ b/autoimport.py @@ -104,14 +104,15 @@ def main(): print("reading database") cur.execute("SELECT name, version FROM package;") - knownpkgs = dict((row[0], row[1]) for row in cur.fetchall()) + knownpkgvers = dict((row[0], row[1]) for row in cur.fetchall()) distpkgs = set(pkgs.keys()) if args.new: for name in distpkgs: - if name in knownpkgs and version_compare(pkgs[name]["version"], - knownpkgs[name]) <= 0: + if name in knownpkgvers and \ + version_compare(pkgs[name]["version"], knownpkgvers[name]) <= 0: del pkgs[name] - knownpkgs = set(knownpkgs) + knownpkgs = set(knownpkgvers) + del knownpkgvers with e: fs = {} -- cgit v1.2.3